Re: [PATCHv2 1/1] Changes from [v1]:

[Миронов Сергей Владимирович <mironov@xxxxxxxxxx>]

OK, thanks Peter.

I will show this when sending patches later.

---

От: Peter Krempa <pkrempa@xxxxxxxxxx>
Отправлено: 11 октября 2023 г. 11:30:48
Кому: Миронов Сергей Владимирович
Копия: libvir-list@xxxxxxxxxx
Тема: Re: [PATCHv2 1/1] Changes from [v1]:

 

On Wed, Oct 11, 2023 at 11:19:08 +0300, Sergey Mironov wrote:
> - now checked devAlias and making the code more robust in case when qemu stop sending a devAlias
>
> [v1] https://listman.redhat.com/archives/libvir-list/2023-October/242544.html

When this is commited to the repository the history of reviews is no
longer important. The commit message should not include it at all and
neither link to previous versions, but rather just state what the patch
is doing.

I'll address that by rewriting the commit message before pushing, so you
don't need to send another version, just keep that in mind for next
time.

>
> Signed-off-by: Sergey Mironov <mironov@xxxxxxxxxx>
>
> ---
> v2: devAlias pointer was checked
> ---
>  src/qemu/qemu_monitor_json.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
> index 5b9edadcf7..e37faff683 100644
> --- a/src/qemu/qemu_monitor_json.c
> +++ b/src/qemu/qemu_monitor_json.c
> @@ -934,7 +934,7 @@ qemuMonitorJSONHandleTrayChange(qemuMonitor *mon,
>      int reason;
> 
>      /* drive alias is always reported but empty for -blockdev */
> -    if (*devAlias == '\0')
> +    if (devAlias && *devAlias == '\0')

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>