On Fri, Apr 23, 2010 at 09:33:20AM +0200, Daniel Veillard wrote: > On Thu, Apr 22, 2010 at 11:41:04PM +0900, Satoru SATOH wrote: > > The following series of patches is a prototype implementation of dnsmasq > > module. > > > > It implements an idea to save dhcp hosts' macaddr vs. ipaddr mappings to > > static file and make dnsmasq loading it with "--dhcp-hostsfile" option, > > originally suggested by Dan-san, and can address the problem that too > > many "--dhcp-host" args hitting ARG_MAX limit I reported last year [1]. > > > > This is a updated version reflecting some advices from Jim-san [2] and > > Eric-san [3]. > > > > > > [1] https://www.redhat.com/archives/libvir-list/2009-October/msg00216.html > > [2] https://www.redhat.com/archives/libvir-list/2010-April/msg00849.html > > [3] https://www.redhat.com/archives/libvir-list/2010-April/msg00850.html > > Hi Satoru, > > looking at the patches, those looks fine to me, I may have just a couple > of cosmetic comments, but I'm wondering if they should be postponed > after 0.8.1, or if it's fine to push them in now. On one hand I would > prefer to limit the number of actual features in 0.8.1, but on the other > hand you have already submitted this many time so I wonder what you > think. When you say "prototype implementation" how confident are you > about this code ? > > So what do you think ? As far as I tested, it works as expected and not aware of any critical issues. So if you're ok, I want to get it merge in. - satoru -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list