On Thu, Oct 05, 2023 at 16:05:01 -0700, Vivek Kashyap wrote:
> Introduce qemu capability for vf-token
>
> Signed-off-by: Vivek Kashyap <vivek.kashyap@xxxxxxxxxxxxxxx>
> ---
> src/qemu/qemu_capabilities.c | 3 +++
> src/qemu/qemu_capabilities.h | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 3a1bfbf74d..f84c4df8db 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -698,6 +698,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
> /* 450 */
> "run-with.async-teardown", /* QEMU_CAPS_RUN_WITH_ASYNC_TEARDOWN */
> "virtio-blk-vhost-vdpa", /* QEMU_CAPS_DEVICE_VIRTIO_BLK_VHOST_VDPA */
> + "vf-token", /* QEMU_CAPS_VFIO_VFTOKEN */
> );
>
>
> @@ -1384,6 +1385,7 @@ struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[] = {
> { "virtio-crypto-device", QEMU_CAPS_DEVICE_VIRTIO_CRYPTO },
> { "cryptodev-backend-lkcf", QEMU_CAPS_OBJECT_CRYPTO_LKCF },
> { "pvpanic-pci", QEMU_CAPS_DEVICE_PANIC_PCI },
> + { "vf-token", QEMU_CAPS_VFIO_VFTOKEN },
> };
>
>
> @@ -1446,6 +1448,7 @@ static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsVirtioSCSI[] = {
> };
>
> static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsVfioPCI[] = {
> + { "vf-token", QEMU_CAPS_VFIO_VFTOKEN, NULL },
Extra trailing whitespace.
> };
Also the 'vf-token' field was added in qemu-8.1 thus you are missing the
appropriate test file updates.
Also the whitespace error would be caught by our test suite.
Please always make sure to post patches where our test suite passes
after every single commit:
https://www.libvirt.org/hacking.html#preparing-patches
Notably you'll need to re-generate the 'qemucapabilitiestest' output
files to include the new flag. To do so automatically run:
VIR_TEST_REGENERATE_OUTPUT=1 ./tests/qemucapabilitiestest
from your build directory after you build everything.
