On 27/9/23 15:30, Thomas Huth wrote:
This subsystem is said to be in a bad shape (see e.g. [1], [2] and [3]), and nobody seems to feel responsible to pick up patches for this and send them via a pull request. For example there is a patch for a CVE-worthy bug posted more than half a year ago [4] which has never been merged. Quoting Markus: "Given the shape it is in, I wouldn't let friends use it in production" - we shouldn't expose this to our users in the current state. Thus let's mark it as deprecated and finally remove it unless somebody steps up and improves the code quality and adds proper regression tests. [1] https://lore.kernel.org/qemu-devel/20230918144206.560120-1-armbru@xxxxxxxxxx/ [2] https://lore.kernel.org/qemu-devel/ZQnojJOqoFu73995@xxxxxxxxxx/ [3] https://lore.kernel.org/qemu-devel/1054981c-e8ae-c676-3b04-eeb030e11f65@xxxxxxxxxx/ [4] https://lore.kernel.org/qemu-devel/20230301142926.18686-1-yuval.shaia.ml@xxxxxxxxx/ [5] https://lore.kernel.org/qemu-devel/8734z9f086.fsf@xxxxxxxxxxxx/ Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx> --- MAINTAINERS | 2 +- docs/about/deprecated.rst | 8 ++++++++ hw/rdma/vmw/pvrdma_main.c | 2 ++ 3 files changed, 11 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
