On Wed, Sep 27, 2023 at 06:19:32PM +0200, Andrea Bolognani wrote: > Currently we only set this for the main sockets, which means > that > > $ systemctl stop virtqemud.socket > > will make the socket disappear from the filesystem while > > $ systemctl stop virtqemud-ro.socket > > won't. Get rid of this inconsistency. systemd recommands against using RemoveOnStop, on the basis that it is valid to keep the service running but stop the socket. We've used deps to ensure thats not possible though, so adding RemoveOnStop isn't creating problems we don't already have. > > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> > --- > src/locking/virtlockd-admin.socket.in | 1 + > src/locking/virtlockd.socket.in | 1 + > src/logging/virtlogd-admin.socket.in | 1 + > src/logging/virtlogd.socket.in | 1 + > src/remote/libvirtd-admin.socket.in | 1 + > src/remote/libvirtd-ro.socket.in | 1 + > src/virtd-admin.socket.in | 1 + > src/virtd-ro.socket.in | 1 + > 8 files changed, 8 insertions(+) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
