Re: [libvirt PATCH 41/42] systemd: Improve and unify unit descriptions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 25, 2023 at 08:58:39PM +0200, Andrea Bolognani wrote:
> Hypervisors are referred to by their user-facing name rather
> than the name of their libvirt driver, the monolithic daemon is
> explicitly referred to as legacy, and a consistent format is
> used throughout.
> 
> Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> ---
>  src/ch/meson.build                    | 2 +-
>  src/interface/meson.build             | 2 +-
>  src/libxl/meson.build                 | 2 +-
>  src/locking/meson.build               | 2 +-
>  src/locking/virtlockd-admin.socket.in | 2 +-
>  src/locking/virtlockd.service.in      | 2 +-
>  src/locking/virtlockd.socket.in       | 2 +-
>  src/logging/meson.build               | 2 +-
>  src/logging/virtlogd-admin.socket.in  | 2 +-
>  src/logging/virtlogd.service.in       | 2 +-
>  src/logging/virtlogd.socket.in        | 2 +-
>  src/lxc/meson.build                   | 2 +-
>  src/network/meson.build               | 2 +-
>  src/node_device/meson.build           | 2 +-
>  src/nwfilter/meson.build              | 2 +-
>  src/qemu/meson.build                  | 2 +-
>  src/remote/libvirtd-admin.socket.in   | 2 +-
>  src/remote/libvirtd-ro.socket.in      | 2 +-
>  src/remote/libvirtd-tcp.socket.in     | 2 +-
>  src/remote/libvirtd-tls.socket.in     | 2 +-
>  src/remote/libvirtd.service.in        | 2 +-
>  src/remote/libvirtd.socket.in         | 2 +-
>  src/remote/meson.build                | 4 ++--
>  src/secret/meson.build                | 2 +-
>  src/storage/meson.build               | 2 +-
>  src/vbox/meson.build                  | 2 +-
>  src/virtd-admin.socket.in             | 2 +-
>  src/virtd-ro.socket.in                | 2 +-
>  src/virtd-tcp.socket.in               | 2 +-
>  src/virtd-tls.socket.in               | 2 +-
>  src/virtd.service.in                  | 2 +-
>  src/virtd.socket.in                   | 2 +-
>  src/vz/meson.build                    | 2 +-
>  33 files changed, 34 insertions(+), 34 deletions(-)
> 

> diff --git a/src/locking/virtlockd-admin.socket.in b/src/locking/virtlockd-admin.socket.in
> index a773b511bd..90077b4915 100644
> --- a/src/locking/virtlockd-admin.socket.in
> +++ b/src/locking/virtlockd-admin.socket.in
> @@ -1,5 +1,5 @@
>  [Unit]
> -Description=Virtual machine lock manager admin socket
> +Description=libvirt @name@ daemon admin socket

Using a subsitution here does not add any value IMHO, it
just obscures the final text. Likewise for the similar
changes that follow.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux