On a Monday in 2023, Jonathon Jongsma wrote:
virProcessKillPainfullyDelay() currently almost always returns 1 or -1, even though the documentation indicates that it should return 0 if the process was terminated gracefully. But the computation of the return code is faulty and the only case that it currently returns 0 is when it is called with the pid of a process that does not exist. Since no callers ever even distinguish between the 0 and 1 response codes, simply get rid of the distinction and return 0 for both cases. Signed-off-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx> --- Change in v2: - just drop the distinction between 0 and 1 and always return 0. Suggested by Ján Tomko src/util/virprocess.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Jano
Attachment:
signature.asc
Description: PGP signature
