Re: [libvirt PATCH 01/42] systemd: Add missing Also for admin socket

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 25, 2023 at 08:57:59PM +0200, Andrea Bolognani wrote:
> When libvirtd, virtlog and virtlockd are enabled, we want their
> admin sockets to be enabled as well.

s/enabled/enabled for socket activation/

because these admin sockets were enabled automatically when the
service eventually starts already.

> 
> Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> ---
>  src/locking/virtlockd.service.in | 1 +
>  src/logging/virtlogd.service.in  | 1 +
>  src/remote/libvirtd.service.in   | 1 +
>  3 files changed, 3 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>

> 
> diff --git a/src/locking/virtlockd.service.in b/src/locking/virtlockd.service.in
> index dd0bbab083..18873f86a6 100644
> --- a/src/locking/virtlockd.service.in
> +++ b/src/locking/virtlockd.service.in
> @@ -22,3 +22,4 @@ LimitNOFILE=1024:524288
>  
>  [Install]
>  Also=virtlockd.socket
> +Also=virtlockd-admin.socket
> diff --git a/src/logging/virtlogd.service.in b/src/logging/virtlogd.service.in
> index 8e245ddb43..14a991f348 100644
> --- a/src/logging/virtlogd.service.in
> +++ b/src/logging/virtlogd.service.in
> @@ -22,3 +22,4 @@ LimitNOFILE=1024:524288
>  
>  [Install]
>  Also=virtlogd.socket
> +Also=virtlogd-admin.socket
> diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in
> index 84f1613adc..8839c00a15 100644
> --- a/src/remote/libvirtd.service.in
> +++ b/src/remote/libvirtd.service.in
> @@ -50,3 +50,4 @@ Also=virtlockd.socket
>  Also=virtlogd.socket
>  Also=libvirtd.socket
>  Also=libvirtd-ro.socket
> +Also=libvirtd-admin.socket
> -- 
> 2.41.0
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux