On 9/3/23 16:58, K Shiva Kiran wrote: > This patchset adds support to trigger an event upon changes in the > content of `<title>`, `<description>` or `<metadata>` in the network. > > K Shiva Kiran (8): > Define Network Metadata change callback function > Define Network event struct for Metadata change > Add Event ID, Server side dispatcher and virsh print function > Add methods to create Metadata change events > Implement RPC Client for Network Metadata change callbacks > Test driver implementation for Network metadata change callbacks > Add Bridge Driver implementation for Network metadata change callbacks > examples: Add Testing for metadata change callbacks > > examples/c/misc/event-test.c | 85 ++++++++++++++++++++++++++--- > include/libvirt/libvirt-network.h | 22 ++++++++ > src/conf/network_event.c | 84 ++++++++++++++++++++++++++++ > src/conf/network_event.h | 11 ++++ > src/libvirt_private.syms | 2 + > src/network/bridge_driver.c | 6 ++ > src/remote/remote_daemon_dispatch.c | 38 +++++++++++++ > src/remote/remote_driver.c | 31 +++++++++++ > src/remote/remote_protocol.x | 15 ++++- > src/remote_protocol-structs | 6 ++ > src/test/test_driver.c | 7 +++ > tools/virsh-network.c | 46 +++++++++++++++- > 12 files changed, 342 insertions(+), 11 deletions(-) > Couple of points: Patches 1-3 can be squashed together. There is no value in having them separate (nobody will ever backport just the callback function definition). Commit message subject usually have a prefix (see git log) respecting the part of the code they are changing. For instance, instead of: Add Bridge Driver implementation for Network metadata change callbacks we would have: network: Implement network metadata change callbacks or: bridge_driver: Implement network metadata change callbacks This makes it easy to "pattern match" when skimming through git log. Nevertheless, these are small nits and I'll fix hem before merging. Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Michal
