Re: [sdl-qemu] [PATCH 0/1] There are no checks, virDomainChrSourceDefNew can return 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 14, 2023 at 13:45:23 +0000, Миронов Сергей Владимирович wrote:

This is a technical list so please avoid top-posting.

> Okay, Peter
> 
> 
> Should I resend the patches correctly or wait for a response for those added to the mailing list?
> 
> 
> https://listman.redhat.com/archives/libvir-list/2023-September/242078.html

This patch make some sense. Please resend it with my and Michal's
comments addressed.

> https://listman.redhat.com/archives/libvir-list/2023-September/242077.html

This patch IMO doesn't make sense at all. Unless you have a proper
justification for it, e.g. a call trace which would prove my assumption
wrong, then there's no need to post that.

If you do have a justification for it, please put it into the commit
message and repost that one as well. Note that my comments from 0/1
apply also to 1/1.




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux