[sdl-qemu] [PATCH 1/1] No checks, dereferencing possible

[Миронов Сергей Владимирович <mironov@xxxxxxxxxx>]

No checks, dereferencing possible.

Return value of a function 'virDomainChrSourceDefNew' 

is dereferenced at qemu_command.c without checking 

for NULL, but it is usually checked for this function.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 1f85f0967b ("ci: jobs.sh: Add back '--no-suite syntax-check --print-errorlogs'")

Signed-off-by: Sergey Mironov <mironov@xxxxxxxxxx>

---

src/qemu/qemu_command.c | 2 ++

 1 file changed, 2 insertions(+)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c

index e84374b4cf..8d11972c88 100644

--- a/src/qemu/qemu_command.c

+++ b/src/qemu/qemu_command.c

@@ -4698,6 +4698,8 @@ qemuBuildVideoCommandLine(virCommand *cmd,

             g_autofree char *name = g_strdup_printf("%s-vhost-user", video->info.alias);

             qemuDomainChrSourcePrivate *chrsrcpriv = QEMU_DOMAIN_CHR_SOURCE_PRIVATE(chrsrc);

 

+           if (chrsrc == NULL)

+                   return -1;

             chrsrc->type = VIR_DOMAIN_CHR_TYPE_UNIX;

             chrsrcpriv->directfd = qemuFDPassDirectNew(name, &videopriv->vhost_user_fd);

--

2.31.1