[libvirt PATCH v2 33/35] ci: helper: Drop the --meson-args/--ninja-args CLI options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



These originally allowed customizing the ci/Makefile script which was
the core of the local container executions. The problem was that
however flexible this may have been, it never mirrored what was being
done as part of the GitLab jobs. Motivated by the effort of mirroring
GitLab jobs locally, these would only ever make sense to be set/used in
interactive shell container sessions where the developer is perfectly
capable of using the right meson/ninja CLI options directly without
going through another shell variable indirection as it was the case
with these ci/helper options.

Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx>
Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
Erik Skultety <eskultet@xxxxxxxxxx>:
---
 ci/helper | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/ci/helper b/ci/helper
index b90dc56ede..c734629731 100755
--- a/ci/helper
+++ b/ci/helper
@@ -75,21 +75,6 @@ class Parser:
             help="path to lcitool (default: $PATH)",
         )
 
-        # Options that are common to all actions that call the
-        # project's build system
-        mesonparser = argparse.ArgumentParser(add_help=False)
-        mesonparser.add_argument(
-            "--meson-args",
-            default="",
-            help="additional arguments passed to meson "
-                 "(eg --meson-args='-Dopt1=enabled -Dopt2=disabled')",
-        )
-        mesonparser.add_argument(
-            "--ninja-args",
-            default="",
-            help="additional arguments passed to ninja",
-        )
-
         # Options that are common to actions communicating with a GitLab
         # instance
         gitlabparser = argparse.ArgumentParser(add_help=False)
-- 
2.41.0




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux