On Thu, Aug 31, 2023 at 23:46:57 +0530, K Shiva Kiran wrote: > Fixes the following bug: > Command: `net-desc --config [--title] my_network` > Expected Output: Title/Description of persistent config > Output: Title/Description of live config > > This was caused due to the usage of a single `flags` variable in > `virshGetNetworkDescription()` which ended up in a wrong enum being > passed to `virNetworkGetMetadata()` (enum being that of LIVE instead of > CONFIG). > > Although the domain object has the same code, this didn't cause a problem > there because the enum values of `VIR_DOMAIN_INACTIVE_XML` and > `VIR_DOMAIN_METADATA_CONFIG` turn out to be the same (1 << 1), whereas > they are not for network equivalent ones (1 << 0, 1 << 1). > > Signed-off-by: K Shiva Kiran <shiva_kr@xxxxxxxxxx> > --- > tools/virsh-network.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) ... Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
