On Thu, Aug 31, 2023 at 16:55:03 +0200, Pavel Hrdina wrote:
> When used with internal snapshots there is no header to be used and no
> memory state to be decompressed.
This ...
>
> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> ---
> src/qemu/qemu_saveimage.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c
> index 73115af42d..2538732901 100644
> --- a/src/qemu/qemu_saveimage.c
> +++ b/src/qemu/qemu_saveimage.c
> @@ -573,7 +573,7 @@ qemuSaveImageOpen(virQEMUDriver *driver,
> * @fd: FD pointer of memory state file
> * @path: path to memory state file
> * @snapshot: snapshot to load when starting QEMU process or NULL
> - * @header: header from memory state file
> + * @header: header from memory state file or NULL
> * @cookie: cookie from memory state file
> * @asyncJob: type of asynchronous job
> * @start_flags: flags to start QEMU process with
... here.
> @@ -605,7 +605,7 @@ qemuSaveImageStartProcess(virConnectPtr conn,
> g_autofree char *errbuf = NULL;
> int rc = 0;
>
> - if ((header->version == 2) &&
> + if (header && (header->version == 2) &&
> (header->compressed != QEMU_SAVE_FORMAT_RAW)) {
> if (!(cmd = qemuSaveImageGetCompressionCommand(header->compressed)))
> return -1;
Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
