Re: [libvirt PATCH 29/33] ci: helper: Rework _lcitool_run method logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 25, 2023 at 07:55:37PM +0200, Erik Skultety wrote:
> This method wasn't even utilized before this patch. This patch adds all
> the necessary logic to successfully execute a container workload via
> lcitool (which will later allow us to ditch ci/Makefile). Because
> container executions via lcitool creates the following inside the
> container:
> 
>     $ ls
>     script datadir
> 
> where 'datadir' is the workload directory (in this case a local git
> repo clone) and 'script' is the code that runs whatever the workload is
> over 'datadir'.
> 
> In order to satisfy the ^above, our helper generates a trivial
> temporary 'script' that will source ci/build.sh and run whatever was
> specified as --job essentially to simulate the exact steps a GitLab
> pipeline job would go through.
> 
> Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx>
> ---
>  ci/helper | 50 ++++++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 48 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux