Re: [libvirt PATCH 32/33] ci: helper: Drop the --meson-args/--ninja-args CLI options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 25, 2023 at 07:55:40PM +0200, Erik Skultety wrote:
> These originally allowed customizing the ci/Makefile script which was
> the core of the local container executions. The problem was that
> however flexible this may have been, it never mirrored what was being
> done as part of the GitLab jobs. Motivated by the effort of mirroring
> GitLab jobs locally, these would only ever make sense to be set/used in
> interactive shell container sessions where the developer is perfectly
> capable of using the right meson/ninja CLI options directly without
> going through another shell variable indirection as it was the case
> with these ci/helper options.
> 
> Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx>
> ---
>  ci/helper | 15 ---------------
>  1 file changed, 15 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux