Re: [libvirt PATCH 06/33] ci: build.sh: Add a wrapper function over the 'build' job

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 25, 2023 at 07:55:14PM +0200, Erik Skultety wrote:
> This helper is a shell function transcript of its original GitLab CI
> counterpart.
> 
> Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx>
> ---
>  ci/build.sh | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/ci/build.sh b/ci/build.sh
> index d4fbf0ab37..c2f54707ce 100644
> --- a/ci/build.sh
> +++ b/ci/build.sh
> @@ -47,3 +47,10 @@ run_meson_setup() {
>  
>      run_cmd "$CMD"
>  }
> +
> +run_build() {
> +    local CMD="meson compile -C build $BUILD_ARGS"
> +
> +    run_meson_setup

Per the previous patch, I think we should do

   test -d $GIT_ROOT/build/build.ninja || run_meson_setup

so that 'run_meson_setup' can do its thing unconditionally if
invoked explicitly

> +    run_cmd "$CMD"
> +}

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux