On Thu, Aug 31, 2023 at 10:29:23AM +0100, Daniel P. Berrangé wrote: > On Thu, Aug 31, 2023 at 02:14:49AM -0700, Andrea Bolognani wrote: > > On Thu, Aug 31, 2023 at 09:50:07AM +0100, Daniel P. Berrangé wrote: > > > I'm not seeing a good way to deal with the upgrade problem though. > > > > Yeah. The two alternatives that I was able to come up with are > > > > 1) documenting in the release notes for Fedora and RHEL that > > people using the monolithic daemon need to run > > > > $ dnf mark install libvirt-daemon > > > > before performing the upgrade; > > > > 2) in libvirt-daemon's %postinst, detect whether libvirtd is > > enabled and if so run the command above. > > > > I don't like 1) because it's really easy to miss something like that, > > and if we're being honest most people don't even read the release > > notes before performing an upgrade. The expectation is that things > > will just work without user intervention, and I don't think it's an > > unreasonable one. > > > > 2) would work but it feels so hacky that I didn't really consider > > proposing it as an actual patch. > > Isnt %postinst too late in the upgrade process for this to work ? I haven't actually tested this approach, but I think it should be fine. The libvirt-daemon package gets updated as expected during upgrade, it's just that *after* the upgrade it's considered an obsolete dependency and thus candidate for autoremoval. So if you run $ dnf update && dnf autoremove the attempt to remove libvirt-daemon will only occur when the second command is executed, by which point %postinst will have already run. > > > Possibly the next step would be to stop building libvirtd by > > > default in upstream releases[1], and figure out a way to attempt > > > to auto switch installs to modular daemons during upgrade. > > > > We have purposefully avoided converting monolithic deployments to > > modular ones so far, but if we want to ever be able to drop the > > monolithic daemon I'm afraid that at some point we'll have to take > > the plunge. The alternatives are breaking all monolithic deployments > > or carrying it around forever. > > Yep, we'll have to bite the bullet eventually and make a decision, > but for now lets keep our heads in the sand a bit longer :-) > > Meanwhile to be explicit about your current patch > > Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Thanks, I'll push it then. -- Andrea Bolognani / Red Hat / Virtualization
