On 8/16/23 20:47, K Shiva Kiran wrote: > Adds two new commands and a new option: > - 'net-desc' to show/modify network title and description. > - 'net-metadata' to show/modify network metadata. > - Option '--title' for 'net-list' to print corresponding > network titles in an additional column. > - Documentation for all the above. > - XML Fallback function `virshNetworkGetXMLFromNet` for title and > description for compatibility with hosts running older versions > of libvirtd. > > Signed-off-by: K Shiva Kiran <shiva_kr@xxxxxxxxxx> > --- > docs/manpages/virsh.rst | 77 ++++++++ > tools/virsh-network.c | 411 ++++++++++++++++++++++++++++++++++++++-- > tools/virsh-util.c | 25 +++ > tools/virsh-util.h | 9 + > 4 files changed, 511 insertions(+), 11 deletions(-) There's too much going on in a single patch. Two new commands are introduced, another one grows new argument. It easily could have been separate patches. The problem with different semantic changes being tangled in one patch is: it's harder to review as reviewer has to track multiple things during review. Subsequently, reviewers tend to pick something better structured and this may then fall through the cracks. Michal
