On Fri, Aug 25, 2023 at 09:39:57AM +0200, Michal Privoznik wrote: > This is inspired by the following discussion: > > https://listman.redhat.com/archives/libvir-list/2023-August/241361.html We have it covered by coding style document so it would be nice to make a syntax-check for it as well so there are no new multi-line errors introduced in the future. Not sure how difficult it would be so definitely as follow up. Otherwise looks good and compiles without issues on my machine. I would consider pushing it after release is done to make sure it will not break anything as it affects basically the whole libvirt code base. > And ideally I'd present a green pipeline but for some reason, I can't: > > https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/981105262 > > But the problem is not with my code rather than our CI. Unless there are objections from others Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
