Re: [libvirt PATCH v3 1/8] util: use "stubDriverType" instead of just "stubDriver"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/21/23 21:32, Laine Stump wrote:
> In the past we just kept track of the type of the "stub driver" (the
> driver that is bound to a device in order to assign it to a
> guest). The next commit will add a stubDriverName to go along with
> type, so lets use stubDriverType for the existing enum to make it
> easier to keep track of whether we're talking about the name or the
> type.
> 
> Signed-off-by: Laine Stump <laine@xxxxxxxxxx>
> ---
>  src/hypervisor/domain_driver.c |  4 ++--
>  src/hypervisor/virhostdev.c    |  8 ++++----
>  src/libvirt_private.syms       |  4 ++--
>  src/util/virnvme.c             |  2 +-
>  src/util/virpci.c              | 16 ++++++++--------
>  src/util/virpci.h              |  6 +++---
>  tests/virhostdevtest.c         |  2 +-
>  tests/virpcitest.c             |  8 ++++----
>  8 files changed, 25 insertions(+), 25 deletions(-)

There's one more occurrence:

diff --git i/src/util/virpci.c w/src/util/virpci.c
index 88a020fb86..d86a81c2b1 100644
--- i/src/util/virpci.c
+++ w/src/util/virpci.c
@@ -1267,9 +1267,10 @@ virPCIDeviceBindToStub(virPCIDevice *dev)
 /* virPCIDeviceDetach:
  *
  * Detach this device from the host driver, attach it to the stub
- * driver (previously set with virPCIDeviceSetStubDriver(), and add *a
- * copy* of the object to the inactiveDevs list (if provided). This
- * function will *never* consume dev, so the caller should free it.
+ * driver (previously set with virPCIDeviceSetStubDriverType(), and
+ * add *a copy* of the object to the inactiveDevs list (if provided).
+ * This function will *never* consume dev, so the caller should free
+ * it.
  *
  * Returns 0 on success, -1 on failure (will fail if the device is
  * already in the activeDevs list, but will be a NOP if the device is


Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux