[PATCH] qemuValidateDomainVCpuTopology: Remove misconfiguration warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Since commit baca59a5384 the NUMA definition is automatically fixed if
the vCPU count mismatches the NUMA cpu count so that this warning will
never be triggered.

Additionally VIR_WARN of a misconfiguration of a VM would not really
be seen in most cases as it's only simply logged.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---

This was originally in my series reworking qemuxml2xmltest. I've removed
it but later figured out that it's dead code. This posting has an
updated commit message.

 src/qemu/qemu_validate.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 28e4a4cc99..9e638894a9 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu/qemu_validate.c
@@ -761,7 +761,6 @@ qemuValidateDomainVCpuTopology(const virDomainDef *def, virQEMUCaps *qemuCaps)
                                                         def->os.machine);
     unsigned int topologycpus;
     unsigned int granularity;
-    unsigned int numacpus;

     if (virDomainDefGetVcpus(def) == 0) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
@@ -785,13 +784,6 @@ qemuValidateDomainVCpuTopology(const virDomainDef *def, virQEMUCaps *qemuCaps)
         }
     }

-    numacpus = virDomainNumaGetCPUCountTotal(def->numa);
-    if ((numacpus != 0) && (topologycpus != numacpus)) {
-        VIR_WARN("CPU topology doesn't match numa CPU count; "
-                 "partial NUMA mapping is obsoleted and will "
-                 "be removed in future");
-    }
-
     /* vCPU hotplug granularity must be respected */
     granularity = qemuValidateDefGetVcpuHotplugGranularity(def);
     if ((virDomainDefGetVcpus(def) % granularity) != 0) {
-- 
2.41.0




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux