When VIR_MIGRATE_TUNNELLED is used without VIR_MIGRATE_NON_SHARED_DISK/VIR_MIGRATE_NON_SHARED_INC an error was reported without actually returning failure. This was caused by a refactor which dropped many error paths. Fixes: 6111b235224 Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> --- src/qemu/qemu_migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index ed41a03851..a3fe6be4e9 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2617,6 +2617,7 @@ qemuMigrationSrcBeginPhase(virQEMUDriver *driver, if (flags & VIR_MIGRATE_TUNNELLED) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", _("migration of non-shared storage is not supported with tunnelled migration and this QEMU")); + return NULL; } if (nmigrate_disks) { -- 2.41.0