Re: [PATCH 07/13] virnetlink: Drop unused variable from virNetlinkCommand()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/3/23 12:36, Michal Privoznik wrote:
> The fds variable inside of virNetlinkCommand() is not used
> really. It's passed to memset() (hence compilers do not
> complain), but that's about it. Drop it.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Reviewed-by: Claudio Fontana <cfontana@xxxxxxx>

> ---
>  src/util/virnetlink.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c
> index 866f4d8f2b..d964c439b4 100644
> --- a/src/util/virnetlink.c
> +++ b/src/util/virnetlink.c
> @@ -333,13 +333,10 @@ int virNetlinkCommand(struct nl_msg *nl_msg,
>              .nl_pid    = dst_pid,
>              .nl_groups = 0,
>      };
> -    struct pollfd fds[1];
>      g_autofree struct nlmsghdr *temp_resp = NULL;
>      g_autoptr(virNetlinkHandle) nlhandle = NULL;
>      int len = 0;
>  
> -    memset(fds, 0, sizeof(fds));
> -
>      if (!(nlhandle = virNetlinkSendRequest(nl_msg, src_pid, nladdr,
>                                             protocol, groups)))
>          return -1;




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux