On Wed, Aug 02, 2023 at 13:47:16 +0200, Kristina Hanicova wrote: > Signed-off-by: Kristina Hanicova <khanicov@xxxxxxxxxx> > --- > docs/formatdomain.rst | 10 ++++++++++ > src/conf/domain_conf.c | 12 +++++++++++- > src/conf/domain_conf.h | 1 + > src/conf/domain_validate.c | 3 ++- > src/conf/schemas/domaincommon.rng | 5 +++++ > 5 files changed, 29 insertions(+), 2 deletions(-) > > diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst > index 0d0812f08c..1fe93066bd 100644 > --- a/docs/formatdomain.rst > +++ b/docs/formatdomain.rst > @@ -2591,6 +2591,13 @@ paravirtualized driver is specified via the ``disk`` element. > <blockio logical_block_size='512' physical_block_size='4096' discard_granularity='4096'/> > <target dev='hdj' bus='ide'/> > </disk> > + <disk type='file' device='disk'> > + <driver name='qemu' type='raw'/> > + <source file='/var/lib/libvirt/images/rhelik.raw'/> > + <target dev='sda' bus='scsi'/> > + <address type='drive' controller='0' bus='0' target='4' unit='0'/> > + <blockio max_unmap_size='1073741824'/> > + </disk> > <disk type='volume' device='disk'> > <driver name='qemu' type='raw'/> > <source pool='blk-pool0' volume='blk-pool0-vol0'/> > @@ -3439,6 +3446,9 @@ paravirtualized driver is specified via the ``disk`` element. > The smallest amount of data that can be discarded in a single operation. > It impacts the unmap operations and it must be a multiple of a > ``logical_block_size``. > + ``max_unmap_size`` > + The maximum size of an unmap operation that can be performed for scsi > + disks. Does this imply that it works only for SCSI disks? The code isn't enforcing that anywhere
