On Fri, Jul 21, 2023 at 8:18 PM Michal Prívozník <mprivozn@xxxxxxxxxx> wrote:
On 7/20/23 10:53, Han Han wrote:
>
>
> On Thu, Jul 20, 2023 at 2:56 PM Michal Prívozník <mprivozn@xxxxxxxxxx
> <mailto:mprivozn@xxxxxxxxxx>> wrote:
>
> On 7/20/23 08:22, Han Han wrote:
> > These two attributes are supported for vhost-user-blk as well.
> >
> > Signed-off-by: Han Han <hhan@xxxxxxxxxx <mailto:hhan@xxxxxxxxxx>>
> > ---
> > docs/formatdomain.rst | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
> > index 4af0b82569..447ab32c01 100644
> > --- a/docs/formatdomain.rst
> > +++ b/docs/formatdomain.rst
> > @@ -3275,9 +3275,9 @@ paravirtualized driver is specified via the
> ``disk`` element.
> > "virtio" ``bus`` and "pci" or "ccw" ``address`` types.
> :since:`Since 1.2.8
> > (QEMU 2.1)`
> > - The optional ``queues`` attribute specifies the number of
> virt queues for
> > - virtio-blk. ( :since:`Since 3.9.0` )
> > + virtio-blk or vhost-user-blk. ( :since:`Since 3.9.0` )
>
> This doesn't feel right. The vhost-user-blk disk was introduced fairly
> recently and 3.9.0 is just ancient. Digging into commits, vhost-user-blk
> disk was introduced in v7.1.0 and I didn't check whether it supported
> the attribute from the very beginning.
>
> Thank you for pointing this out. It looks libvirt allows the user to
> set the queues for
> all the bus=='virtio':
> https://gitlab.com/libvirt/libvirt/-/blob/v7.1.0/src/conf/domain_validate.c#L465 <https://gitlab.com/libvirt/libvirt/-/blob/v7.1.0/src/conf/domain_validate.c#L465>
>
> So vhost-user-blk could use the queues at the beginning.
Okay, can you post v2 then please? I'll review it.
Michal
