On 7/17/23 10:58, Peter Krempa wrote: > On Mon, Jul 03, 2023 at 16:53:28 -0600, Matt Low wrote: >> The current virtStorageBackendZFSCheckPool checks for the existence of a >> path under /dev/zvol/ to determine if the pool is active. ZFS does not >> create a path under /dev/zvol/ if no ZFS volumes have been created under >> a particular dataset, thus, empty ZFS storage pools are deactivated >> whenever checkPool is called on them (as noted in referenced issue). >> >> This commit changes virStorageBackendZFSCheckPool so that the 'zfs list' >> command is used to explicitly check for the existence a dataset >> specified by the pool's def->source.name. >> >> Resolves: https://gitlab.com/libvirt/libvirt/-/issues/221 >> >> Signed-off-by: Matt Low <matt@xxxxxxx> >> --- >> src/storage/storage_backend_zfs.c | 20 +++++++++++++++++--- >> 1 file changed, 17 insertions(+), 3 deletions(-) > > Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx> > > I'll push it shortly. > Pushed now. Michal
