On Mon, Jul 17, 2023 at 03:04:56PM +0200, Benedek Major wrote: > Hello, > thanks for your fast responses. > I've also recognized flaws in my implementation, after your comments, so > I'll try to find a solution, that is acceptable, and create a better patch. > But first, I'll need to know if this approach is correct: > > > my interpretation is that the SCSI "product" field data is identical > > to the ATAPI "model" field data. > > AFAICT, ATAPI doesn't provide a way to expose a vendor in string > > format. So I would say we accept 'product' for IDE, but reject > > 'vendor' > I would also say so. > Therefore I would need to expand the vendor field to 40 Chars, if a SATA/IDE > bus is selected. (current is 8 for SCSI). > > about this: > > an IDENTIFY DEVICE / IDENTIFY PACKET DEVICE command on some *real* > > hardware > With hdparm -I /dev/sdX I got: > Model Number: TOSHIBA DT01ACA050 > Model Number: Samsung SSD 850 EVO 250GB > > I think hdparam just dumps the raw responses, but correct me if I'm wrong. I've checked the source and you're correct, this the exact model string. So it seems in practice the model contains both the vendor and product strings, which validates your proposal to do the same in libvirt. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
