Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

[Boris Fiuczynski <fiuczy@xxxxxxxxxxxxx>]

On 7/5/23 8:20 AM, Boris Fiuczynski wrote:
> @@ -6694,6 +6706,13 @@ qemuDomainDefFormatBufInternal(virQEMUDriver *driver,
>                   }
>               }
>           }
> +
> +        /* Remove asynchronous teardown enablement for backwards compatibility
> +         * on S390 as it gets autogenerated on S390 if supported anyway.
> +         */
> +        if (ARCH_IS_S390(def->os.arch) &&
> +            def->features[VIR_DOMAIN_FEATURE_ASYNC_TEARDOWN] != VIR_TRISTATE_BOOL_YES)
> +            def->features[VIR_DOMAIN_FEATURE_ASYNC_TEARDOWN] = VIR_TRISTATE_BOOL_ABSENT;
>       }

Just realized that this is incorrect.
It must be:

if (ARCH_IS_S390(def->os.arch) &&
    def->features[VIR_DOMAIN_FEATURE_ASYNC_TEARDOWN] == 
VIR_TRISTATE_BOOL_YES)
    def->features[VIR_DOMAIN_FEATURE_ASYNC_TEARDOWN] = 
VIR_TRISTATE_BOOL_ABSENT;

Please let me now if I need to resend this series. Thanks.

--
Mit freundlichen Grüßen/Kind regards
   Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294