On 6/11/23 21:44, K Shiva wrote: > Adds support for the following to Network Object: > - <metadata>, <title> and <description> added to Network obj Schema. > - Public Get and Set APIs, being virNetworkSetMetadata() & > virNetworkGetMetadata(). > - An async callback that notifies of changes to Network metadata. > > Resolves (GSoC 2023): https://wiki.libvirt.org/Google_Summer_of_Code_Ideas.html > Signed-off-by: K Shiva <shiva_kr@xxxxxxxxxx> > --- > include/libvirt/libvirt-domain.h | 2 +- > include/libvirt/libvirt-network.h | 51 ++++ > include/libvirt/virterror.h | 2 + > po/POTFILES | 1 + > src/conf/network_conf.c | 3 + > src/conf/network_conf.h | 2 + > src/conf/network_event.c | 115 +++++++++ > src/conf/network_event.h | 11 + > src/conf/virnetworkobj.c | 347 ++++++++++++++++++++++++++-- > src/conf/virnetworkobj.h | 56 +++++ > src/driver-network.h | 16 ++ > src/libvirt-network.c | 167 +++++++++++++ > src/libvirt_public.syms | 6 + > src/remote/remote_daemon_dispatch.c | 39 ++++ > src/remote/remote_driver.c | 32 +++ > src/remote/remote_protocol.x | 15 +- > src/remote_protocol-structs | 6 + > src/test/test_driver.c | 74 ++++++ > src/util/virerror.c | 3 + > tests/meson.build | 1 + > tests/networkmetadatatest.c | 297 ++++++++++++++++++++++++ > tools/virsh-network.c | 78 ++++++- > 22 files changed, 1299 insertions(+), 25 deletions(-) > create mode 100644 tests/networkmetadatatest.c There's too much happening in this patch. I suggest you split it into smaller ones. For instance: in the first introduce just XML parsing/formatting and saving into the XML file stored on the disk. In the second introduce public APIs, in the fourth virsh, then in another one event, etc. The rule of the thumb here is to put yourself into shoes of reviewer and ask yourself "Would I be comfortable reviewing this patch". Michal
