Thomas Huth <thuth@xxxxxxxxxx> wrote:
> On 12/06/2023 21.33, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela <quintela@xxxxxxxxxx>
>> ---
>> docs/about/deprecated.rst | 8 ++++
>> qapi/migration.json | 92 ++++++++++++++++++++++++---------------
>> migration/options.c | 13 ++++++
>> 3 files changed, 79 insertions(+), 34 deletions(-)
>> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
>> index 173c5ba5cb..fe7f2bbde8 100644
>> --- a/docs/about/deprecated.rst
>> +++ b/docs/about/deprecated.rst
>> @@ -460,3 +460,11 @@ block migration (since 8.1)
>> Block migration is too inflexible. It needs to migrate all block
>> devices or none. Use driver_mirror+NBD instead.
>> +old compression method (since 8.1)
>> +''''''''''''''''''''''''''''''''''
>> +
>> +Compression method fails too much. Too many races. We are going to
>> +remove it if nobody fixes it. For starters, migration-test
>> +compression tests are disabled becase they hand randomly. If you need
>
> "because they fail randomly" ?
yeap.
>> # @deprecated: @disk migration is deprecated. Use driver_mirror+NBD
>> -# instead.
>> +# instead. @compression is obsolete use multifd compression
>
> Use a dot or comma after "obsolete".
fixed.
>> @@ -503,6 +506,7 @@
>> # Features:
>> #
>> # @deprecated: @block migration is deprecated. Use driver_mirror+NBD
>> +# instead. @compress is obsolete use multifd compression methods
>
> dito
fixed.
>> -# @compress-threads: compression thread count
>> +# @compress-threads: compression thread count. Obsolote and
>
> Obsolete
Fixed.
>> @@ -1182,7 +1209,6 @@
>> 'features': [ 'unstable' ] },
>> '*block-incremental': { 'type': 'bool',
>> 'features': [ 'deprecated' ] },
>> - '*block-incremental': 'bool',
>
> That hunk should go into a previous patch, I think.
Have found it already (it didn't compile).
Thanks, Juan.
