Re: [libvirt PATCH 9/9] util: add logging about node suspend availability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 22, 2023 at 10:27:15AM +0200, Peter Krempa wrote:
> On Wed, Jun 21, 2023 at 14:32:32 +0100, Daniel P. Berrangé wrote:
> > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> > ---
> >  src/util/virnodesuspend.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/src/util/virnodesuspend.c b/src/util/virnodesuspend.c
> > index 01f387d6fa..91a7f10eb9 100644
> > --- a/src/util/virnodesuspend.c
> > +++ b/src/util/virnodesuspend.c
> > @@ -249,6 +249,7 @@ virNodeSuspendSupportsTargetPMUtils(unsigned int target, bool *supported)
> >      * (i.e., the PM capability is supported)
> >      */
> >      *supported = (status == 0);
> > +    VIR_DEBUG("Node systemd pm-utils target %d: %d", target, *supported);
> 
> ...
> 
> >  
> >      return 0;
> >  }
> > @@ -257,6 +258,7 @@ static int
> >  virNodeSuspendSupportsTargetPMUtils(unsigned int target G_GNUC_UNUSED,
> >                                      bool *supported G_GNUC_UNUSED)
> >  {
> > +    VIR_DEBUG("Node systemd pm-utils target %d: unsupported platform", target);
> 
> ... extra 'systemd' ?
> 
> >      return -2;
> >  }
> >  #endif /* ! WITH_PM_UTILS */
> > @@ -282,6 +284,7 @@ virNodeSuspendSupportsTargetSystemd(unsigned int target, bool *supported)
> >          return ret;
> >      }
> >  
> > +    VIR_DEBUG("Node systemd systemd target %d: %d", target, ret);
> 
> systemd systemd?

All the above cases where supposed to say 'Node suspend ....'
not "Node systemd ....'

> 
> >      return ret;
> >  }
> 
> Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux