On Wed, May 24, 2023 at 02:39:46PM +0100, Alex Bennée wrote:
> This makes it a little easier for developers to find where things
> where being generated.
>
> Reviewed-by: Richard Henderson <richard.henderson@xxxxxxxxxx>
> Signed-off-by: Alex Bennée <alex.bennee@xxxxxxxxxx>
> Message-Id: <20230523125000.3674739-5-alex.bennee@xxxxxxxxxx>
> ---
> scripts/qapi/gen.py | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py
> index 8f8f784f4a..2ea27ef31c 100644
> --- a/scripts/qapi/gen.py
> +++ b/scripts/qapi/gen.py
> @@ -13,6 +13,7 @@
>
> from contextlib import contextmanager
> import os
> +import sys
> import re
> from typing import (
> Dict,
> @@ -162,7 +163,7 @@ def __init__(self, fname: str, blurb: str, pydoc: str):
>
> def _top(self) -> str:
> return mcgen('''
> -/* AUTOMATICALLY GENERATED, DO NOT MODIFY */
> +/* AUTOMATICALLY GENERATED by %(tool)s DO NOT MODIFY */
>
> /*
> %(blurb)s
> @@ -174,6 +175,7 @@ def _top(self) -> str:
> */
>
> ''',
> + tool=str(os.path.basename(sys.argv[0])),
Why is str() used here? %s already produces a string representation of
whatever value you give it (e.g. '%s' % 123 -> '123').
Reviewed-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
