2010/4/20 Eric Blake <eblake@xxxxxxxxxx>: > On 04/18/2010 07:47 AM, Matthias Dahl wrote: >> This is a "quick" implementation to support the qemu aio drive option. I tried >> to stay true to the coding style and this has been tested w/ libvirt 0.7.6 and >> works just fine. >> >> Since I am not that familiar w/ the inner workings of libvirt, I am sure I >> missed a few spots, so I hope either someone will base his work on this patch >> or point me into the right direction so I can finish this up for good. :-) > > This is a decent start, but it's still missing XML definition, remote > protocol support, and virsh support. docs/api_extension gives a sample > patch series that shows all the pieces that are necessary for enhancing > the API. This is just an domain XML extension. Why does it need remote protocol support or virsh support? Parts that are really missing: Documenting this new domain XML attribute in docs/formatdomain.html.in and updating the docs/schemas/domain.rng. Once that done I would consider this patch as complete. Matthias -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list