On Thu, May 18, 2023 at 02:59:39PM +0200, Laszlo Ersek wrote: > The type='pty' attribute in the <serial> element causes a Pseudo TTY to be > allocated on the host side via "/dev/ptmx", which is meant to be > interacted with via "virsh console" or similar. > > That's not how a firmware log is typically viewed or saved. Replace > type='pty' with type='file', and also provide an example <source> element > (with the pathname of the logfile), similarly to how the <serial> example > just above provides a <source> element too. > > Cc: "Daniel P. Berrangé" <berrange@xxxxxxxxxx> > Cc: Andrea Bolognani <abologna@xxxxxxxxxx> > Updates: 654968381df0256c047d2ecd4542ccc90dc57ad0 > Signed-off-by: Laszlo Ersek <lersek@xxxxxxxxxx> > --- > > Notes: > context:-U6 > > docs/formatdomain.rst | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) I see you've already pushed the patches but, just for completeness' sake: Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> -- Andrea Bolognani / Red Hat / Virtualization
