On Sun, Apr 30, 2023 at 11:19:16PM -0400, Laine Stump wrote: > We will already need a separate function for virFirewallApplyRule for > iptables vs. nftables, but the only reason for needing a separate > function for virFirewallAddRule* is that iptables/ebtables need to > have an extra arg added for locking (to prevent multiple iptables > commands from running at the same time). We can just as well add > in the -w/--concurrent during virFirewallApplyRule, so move the arg-add to > ApplyRule to keep AddRule simple. > > Signed-off-by: Laine Stump <laine@xxxxxxxxxx> > --- > src/util/virfirewall.c | 27 +++++++++++++-------------- > 1 file changed, 13 insertions(+), 14 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
