Re: [PATCH 08/11] qemuhotplugtest: Fix misleading comment on monitor unlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 






On Fri, Apr 21, 2023 at 10:25 AM Michal Privoznik <mprivozn@xxxxxxxxxx> wrote:
There's a comment in testQemuHotplug() trying to explain why we
need to unlock the monitor object. Well, while it might have been
correct when being introduced, it's no long factually correct as
*no longer 
just any function (attach/detach/update) might talk to the
monitor and it expects the monitor to be unlocked (as it calls
qemuDomainObjEnterMonitor() + qemuDomainObjExitMonitor()).

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
 tests/qemuhotplugtest.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Kristina Hanicova <khanicov@xxxxxxxxxx>

Kristina
 

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux