Re: [PATCH 05/11] qemuhotplugtest: Call qemuDomainAttachDeviceLive() directly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Fri, Apr 21, 2023 at 10:25 AM Michal Privoznik <mprivozn@xxxxxxxxxx> wrote:
There's no reason for qemuhotplugtest to reimplement which device
attach function to call (testQemuHotplugAttach()) when
qemuDomainAttachDeviceLive() already does that. Thus, drop
testQemuHotplugAttach() and call qemuDomainAttachDeviceLive()
directly.

There's one small catch though, qemuDomainAttachDeviceLive() now
calls one monitor command more (to list all aliases). We don't
care really, because we're not testing that. Therefore, just
provide a dummy reply.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
 tests/qemuhotplugtest.c | 68 +++++------------------------------------
 1 file changed, 7 insertions(+), 61 deletions(-)
Reviewed-by: Kristina Hanicova <khanicov@xxxxxxxxxx>

Kristina
 

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux