On Tue, Apr 18, 2023 at 05:18:04PM +0000, Nick Guenther wrote: > April 18, 2023 3:37 AM, "Peter Krempa" <pkrempa@xxxxxxxxxx> wrote: > > In fact libvirt is already using this folder for tracking qemu's PIDs: > > /run/user/703204575/libvirt/qemu > └── run > ├── abcdefg.pid > ├── abcdefg.xml > ├── abcdef.pid > ├── abcdef.xml > ├── abcde.pid > ├── abcde.xml > ├── abcd.pid > ├── abcd.xml > ├── a.pid > ├── autostarted > ├── a.xml > ├── dbus > ├── driver.pid > └── slirp > > 3 directories, 12 files > > We could move the rest in there and fix the bug. I'd also like to > incorporate your suggestion of dropping the "target" subfolder, > and maybe picking either just `domain-$N` or `$name` instead of > `domain-$N-$name`. > > Thoughts? Yes, it is rather strange that we put any of the UNIX socket paths under our so called 'lib' directory and not under 'run'. ALl the UNIX sockets really should be in the same place as the .pid files as they're not persistent state. Can't recall why we made this wierd decision over a decade ago :-) I'm certainly open to us correcting this oddity assuming we get the upgrade path right and selinux policy is likewise ok with it. Neither should be a hard problem (if any). With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
