Re: [PATCH v3 22/25] qemu: Store all iothread's 'poll*' attributes as unsigned long long

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Wednesday in 2023, Peter Krempa wrote:
Convert the internal types to unsigned long long. Luckily we can also
covert the external types too:

- 'qemuDomainSetIOThreadParams' can accept both _UINT and _ULLONG by
  converting to 'virTypedParamsGetUnsigned'

- querying is handled via the bulk stats API which is flexible:
   - we use virTypedParamListAddUnsigned to use the bigger type only if
     necessary
   - most users don't even notice because the bindings abstract the
     data types

Apart from the code modifications we also improve the documenataion

*documentation

which was missing for the setters.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
include/libvirt/libvirt-domain.h |  4 +++-
src/libvirt-domain.c             | 14 +++++++----
src/qemu/qemu_driver.c           | 28 +++++++++++-----------
src/qemu/qemu_monitor.h          |  4 ++--
src/qemu/qemu_monitor_json.c     | 41 ++++++++++++++++++++------------
5 files changed, 54 insertions(+), 37 deletions(-)


Jano

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux