Re: [PATCH v3 03/10] accel/tcg: Use one_insn_per_tb global instead of old singlestep global

[Richard Henderson <richard.henderson@xxxxxxxxxx>]

On 4/17/23 18:40, Peter Maydell wrote:
> @@ -219,8 +221,8 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool value, Error **errp)
>   {
>       TCGState *s = TCG_STATE(obj);
>       s->one_insn_per_tb = value;
> -    /* For the moment, set the global also: this changes the behaviour */
> -    singlestep = value;
> +    /* Set the global also: this changes the behaviour */
> +    qatomic_set(&one_insn_per_tb, value);
>   }

Oh, one question: is it worth having the TCGState member at all?
Seems like these accessors could work just fine with only the global.


r~