Re: [PATCH 2/3] qemu: Change default machine type for riscv64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 14, 2023 at 03:14:48PM -0600, Jim Fehlig wrote:
> It's quite difficult, if not impossible, to create a working riscv64 VM
> using the current default machine type of 'spike_v1.10'. Change the
> default to the more appropriate and virtualization friendly 'virt'
> machine type.
>
> Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx>
> ---
>  src/qemu/qemu_capabilities.c                      | 2 +-
>  tests/qemucapabilitiesdata/caps_5.0.0_riscv64.xml | 2 +-
>  tests/qemucapabilitiesdata/caps_5.2.0_riscv64.xml | 2 +-
>  tests/qemucapabilitiesdata/caps_8.0.0_riscv64.xml | 4 ++--
>  4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 9ec283db63..687e36e243 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -2715,7 +2715,7 @@ static const char *preferredMachines[] =
>      "bamboo", /* VIR_ARCH_PPCEMB */
>
>      "spike_v1.10", /* VIR_ARCH_RISCV32 */
> -    "spike_v1.10", /* VIR_ARCH_RISCV64 */
> +    "virt", /* VIR_ARCH_RISCV64 */

Same comment as the previous patch: no reason to limit this change to
riscv64 when riscv32 would benefit from it just the same. Please
change the default machine type for both architectures.

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux