On Wed, Apr 12, 2023 at 12:55:51PM +0200, Ján Tomko wrote:
> On a Tuesday in 2023, Andrea Bolognani wrote:
> > static int
> > virDomainDefParseBootFirmwareOptions(virDomainDef *def,
> > - xmlXPathContextPtr ctxt)
> > + xmlXPathContextPtr ctxt,
> > + unsigned int flags)
> > {
> > g_autofree char *firmware = virXPathString("string(./os/@firmware)", ctxt);
> > g_autofree xmlNodePtr *nodes = NULL;
> > g_autofree int *features = NULL;
> > + bool abiUpdate = !!(flags & VIR_DOMAIN_DEF_PARSE_ABI_UPDATE);
>
> The flag is documented as:
> /* allow updates in post parse callback that would break ABI otherwise */
> VIR_DOMAIN_DEF_PARSE_ABI_UPDATE = 1 << 7,
>
> and I also think that this is something that better belongs in
> post-parse.
Okay, so the idea would be to keep picking up the firmware features
here and possibly drop them from the DomainDef during the PostParse
phase? I think that could work too. Let me give it a try.
--
Andrea Bolognani / Red Hat / Virtualization
