On a Thursday in 2023, Peter Krempa wrote:
Historically the snapshot code attempted to forbid internal snapshots with UEFI both in active and inactive case. Unfortunately due to the intricacies of UEFI probing this didn't really work for inactive VMs which made users rely on the feature. Now with the changes to store detected UEFI environment also in the inactive definition this broke the feature for those users. Since the varstore doesn't really change that much in the lifecycle of a VM it usually is okay to simply leave it as is. Restore the functionality for inactive snapshots by disabling the check. In the future when uefi snapshotting will be added the rest of the condition will also be removed. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/460 Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> --- src/qemu/qemu_snapshot.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Jano
Attachment:
signature.asc
Description: PGP signature
