Greetings Sir
My apologies for the incorrect formats as I am a beginner to git. Thank you very much for your corrections.
I have a few questions:
Can Questions and doubts be posted within the same mail that
consists a patch file? Or should they be put in a separate email
(as I am attempting to do now)?
As per your instruction to make the functions static, I was able
to make the below function (created by me) static by calling it
from virDomainGraphicsDefListensValidate() within
domain_validate.c
static int
virDomainGraphicsListenDefValidate(const virDomainGraphicsListenDef *def,
const virDomainGraphicsDef *graphics)
Similarly,In this patch: Link
I had created a function named;
int virDomainStorageNetHostSocketValidate(const virStorageNetHostDef *host,
const char *transport);
that removes the validation checks of socket in
virDomainStorageNetworkParseHost().
While I found a function to call Graphics Validation within
validate.c, I am unable to find a function that can be used to
call NetworkHostSocketValidate() from within domain_validate.c.
Could you please provide a pointer on how it could be done?
Thank you in advance.
Shiva
