On Mon, Mar 13, 2023 at 16:42:13 +0100, Pavel Hrdina wrote: > Before external snapshot revert every delete operation did block commit > in order to delete a snapshot. But now when user reverts to non-leaf > snapshot deleting leaf snapshot will not have any overlay files so we > can just simply delete the snapshot images. > > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> > --- > src/qemu/qemu_snapshot.c | 102 ++++++++++++++++++++++++--------------- > 1 file changed, 62 insertions(+), 40 deletions(-) > > diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c > index d545c984ce..6ff18d7a9e 100644 > --- a/src/qemu/qemu_snapshot.c > +++ b/src/qemu/qemu_snapshot.c > @@ -2476,6 +2476,7 @@ qemuSnapshotFindParentSnapForDisk(virDomainMomentObj *snap, > static int > qemuSnapshotDeleteExternalPrepareData(virDomainObj *vm, > virDomainMomentObj *snap, > + bool blockCommit, > GSList **externalData) This function is starting to get into the region of needing documentation after the flag was added. Also I'd call it a bit differently to de-emphasise that block commit is used, but rather that we are merging images. Either way: Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
