Re: [PATCH v2 01/10] make one-insn-per-tb an accel option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/3/23 07:46, Peter Maydell wrote:
This commit adds 'one-insn-per-tb' as a property on the TCG
accelerator object, so you can enable it with
    -accel tcg,one-insn-per-tb=on

It has the same behaviour as the existing '-singlestep' command line
option.  We use a different name because 'singlestep' has always been
a confusing choice, because it doesn't have anything to do with
single-stepping the CPU.  What it does do is force TCG emulation to
put one guest instruction in each TB, which can be useful in some
situations (such as analysing debug logs).

The existing '-singlestep' commandline options are decoupled from the
global 'singlestep' variable and instead now are syntactic sugar for
setting the accel property.  (These can then go away after a
deprecation period.)

The global variable remains for the moment as:
  * what the TCG code looks at to change its behaviour
  * what HMP and QMP use to query and set the behaviour

In the following commits we'll clean those up to not directly
look at the global variable.

Signed-off-by: Peter Maydell<peter.maydell@xxxxxxxxxx>
---
  accel/tcg/tcg-all.c | 21 +++++++++++++++++++++
  bsd-user/main.c     |  8 ++++++--
  linux-user/main.c   |  8 ++++++--
  softmmu/vl.c        | 17 +++++++++++++++--
  qemu-options.hx     |  7 +++++++
  5 files changed, 55 insertions(+), 6 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@xxxxxxxxxx>

r~




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux