On 04/16/2010 07:31 AM, Daniel P. Berrange wrote: >> --- a/daemon/libvirtd.h >> +++ b/daemon/libvirtd.h >> @@ -45,6 +45,7 @@ >> # include <rpc/types.h> >> # include <rpc/xdr.h> >> # include "remote_protocol.h" >> +# include "qemu_protocol.h" > > I'm thinking this is possibly redundant - I feel it should be possible > to just include it in either the remote.c or dispatch.c file where > it is needed. Indeed the same probably applies for remote_protocol.h > too Unfortunately, with the way things stand now you have to include remote_protocol.h here. libvirtd.h itself depends on the REMOTE_MESSAGE_MAX and REMOTE_MESSAGE_HEADER_XDR_LEN defines, and dispatch.h includes libvirtd.h to get access to the remote_error and remote_message_header structures. I could move just qemu_protocol.h out of here and into remote.c, but it seems like remote_protocol.h and qemu_protocol.h remain logically together, so I left this as-is for now. I've incorporated the rest of your comments from this mail. -- Chris Lalancette -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list