> I would suggest that before pushing, you reorder the patches so that > 'make check' passes for every stage of the patch series. This makes > patch bisection easier in the future (if we are trying to hunt down a > regression, it's better if every commit builds independently). > Admittedly, it can look a bit odd seeing the commit that fixes the bug > before the commit that introduces the test, even though they were > developed in the opposite order, but you get used to it. And 'git > rebase -i' makes it so easy to do. Well, to be honest, I first fixed the bug and then created the tests to check I don't regress somewhere else, to check the bug is really fix and for the future :-) I reordered the patches before posting as they seemed more logical this way. But I can reorder them back, no problem. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list