Re: [PATCH] Revert "ci: Disable optimization on macos-12"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/24/23 16:54, Martin Kletzander wrote:
> This reverts commit 1f76b5365ec78b1e9a36038db8e13ec0025bbe7a.
> 
> There were two issues with this commit.  First is the missing propagation
> of CFLAGS into the build environment and second is the fact that this is
> not enough to disable the check for -fsemantic-interposition.  The
> proper fix would require setting MESON_OPTS or similar and also add the
> propagation of such variable into the cirrus builds etc., but at this
> point I burned so much time on this trivial piece of rubbish that I
> think it's easier to just wait for macos to gain a newer clang =D
> 
> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> ---
>  ci/gitlab/builds.yml | 1 -
>  ci/manifest.yml      | 2 --
>  2 files changed, 3 deletions(-)

Yeah, sorry for setting you on a misleading path.

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

if my ACK still counts...

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux